Remove source builds of geometric_shapes and srdfdom
#3233
+3
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
added
the
backport-jazzy
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3233 +/- ##
==========================================
- Coverage 45.66% 45.63% -0.03%
==========================================
Files 714 714
Lines 62296 62294 -2
Branches 7530 7529 -1
==========================================
- Hits 28444 28421 -23
- Misses 33686 33706 +20
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
|
Bleh. This error seems familiar but I forget what it was. Update: Ended up ignoring it, and it makes CI pass, but unclear whether this is right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had added these a few months back to circumvent some breakages, but this should no longer be needed.
Q: Should we backport this to Jazzy? Because if so,
srdfdomthere is at 2.0.5 and not 2.0.7, so I think we may need to first release to there. But I also forget whether thesrdfdomversion was actually a problem in Jazzy, or it was just Rolling. I guess it's worth just testing the backport?Checklist